Merged
Conversation
laraujo7
force-pushed
the
la/source_controller-tests
branch
2 times, most recently
from
b38e1cc to
752c5af
Compare
|
|
||
| test "deletes source when events are older than 24h", %{conn: conn, source: source} do | ||
| Counters.create(source.token) | ||
| stub(SourceSupervisor, :delete_source, fn _ -> {:ok, source.token} end) |
Contributor
There was a problem hiding this comment.
Can we just add an expect instead of stubbing this one? 🙏
laraujo7
force-pushed
the
la/source_controller-tests
branch
from
752c5af to
f5384d2
Compare
laraujo7
force-pushed
the
la/source_controller-tests
branch
from
f5384d2 to
884af99
Compare
Ziinc
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.