Skip to content

Conversation

@ameybh
Copy link
Contributor

@ameybh ameybh commented Aug 12, 2025

Summary by CodeRabbit

  • New Features

    • Improved accordion open/close animations for smoother, more responsive interactions.
  • Style

    • Adjusted accordion inner spacing for better readability and visual balance.
    • Harmonized animation behavior between open and closed states.
  • Chores

    • Added an animation library and imported it into global styles to enable the new animations.

@vercel
Copy link

vercel bot commented Aug 12, 2025

@ameytessact is attempting to deploy a commit to the Retro UI Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 12, 2025

Walkthrough

Adds tw-animate-css import to global CSS, updates Accordion component classes (removes transition-all, reorders animation classes, adjusts inner padding), and adds tw-animate-css to package.json dependencies. No exported/public API signatures changed.

Changes

Cohort / File(s) Summary
Global CSS import
app/global.css
Added @import "tw-animate-css"; immediately after the existing Tailwind import; no keyframes or animation rules were added.
Accordion component changes
components/retroui/Accordion.tsx
Removed transition-all from the content container, reordered/retained data-[state=open]:animate-accordion-down and data-[state=closed]:animate-accordion-up, and changed inner wrapper padding from pb-4 pt-0 to px-4 pt-2 pb-4; no public API changes.
Dependency addition
package.json
Added dependency "tw-animate-css": "^1.3.7" to dependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop and tweak a class or two,
A tiny import, a padding new.
Accordion hums a softer tune,
Little moves beneath the moon.
— a rabbit, pleased with subtle hue 🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fb6a001 and a987812.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • app/global.css (1 hunks)
  • package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • app/global.css
  • package.json
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ameybh ameybh force-pushed the animated-accordion branch from 10da935 to d12e33d Compare August 12, 2025 19:06
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
components/retroui/Accordion.tsx (1)

52-52: Confirm font-body exists in your Tailwind theme.

font-body isn’t defined in the provided theme vars (we see --font-head and --font-sans). If font-body is a custom Tailwind token, OK; otherwise, this class may be a no-op. Consider font-sans or a custom utility backed by --font-sans.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f23ccbe and d12e33d.

📒 Files selected for processing (2)
  • app/global.css (1 hunks)
  • components/retroui/Accordion.tsx (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
components/retroui/Accordion.tsx (1)
lib/utils.ts (1)
  • cn (4-6)

@ariflogs
Copy link
Member

This will fix things in the RetroUI website, but users will not be able to use this benefit unless they copy our CSS file.
Any ideas how we can handle this?

@ameybh
Copy link
Contributor Author

ameybh commented Aug 13, 2025

We might be able to solve this by creating an tailwind config file that will need to be copied as well. Similar to how shadcn defined keyframes.

https://github.com/shadcn-ui/ui/blob/a941287411e4cf4eca29779a8220d59bfca2a25c/tailwind.config.cjs#L78C1-L83C7

@ariflogs
Copy link
Member

ariflogs commented Aug 13, 2025

Think we can get this with Tailwind, additional CSS won't be required. Check out → https://www.npmjs.com/package/tw-animate-css

Shadcn is using this in the latest Tailwind v4 version.

@ameybh
Copy link
Contributor Author

ameybh commented Aug 18, 2025

Hi @ariflogs, it should be working now. I’ve added the tw-animate-css library and updated the accordion classes for the opening and collapsing animations.

@vercel
Copy link

vercel bot commented Aug 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
retro-ui Ready Ready Preview Comment Aug 19, 2025 11:40am

@ariflogs ariflogs merged commit 82ce613 into Logging-Studio:main Aug 19, 2025
3 checks passed
@ameybh ameybh deleted the animated-accordion branch August 19, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants