-
-
Notifications
You must be signed in to change notification settings - Fork 43
added height animations for accordion component #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ameytessact is attempting to deploy a commit to the Retro UI Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughAdds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
10da935 to
d12e33d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🧹 Nitpick comments (1)
components/retroui/Accordion.tsx (1)
52-52: Confirmfont-bodyexists in your Tailwind theme.
font-bodyisn’t defined in the provided theme vars (we see--font-headand--font-sans). Iffont-bodyis a custom Tailwind token, OK; otherwise, this class may be a no-op. Considerfont-sansor a custom utility backed by--font-sans.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/global.css(1 hunks)components/retroui/Accordion.tsx(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
components/retroui/Accordion.tsx (1)
lib/utils.ts (1)
cn(4-6)
|
This will fix things in the RetroUI website, but users will not be able to use this benefit unless they copy our CSS file. |
|
We might be able to solve this by creating an tailwind config file that will need to be copied as well. Similar to how shadcn defined keyframes. |
|
Think we can get this with Tailwind, additional CSS won't be required. Check out → https://www.npmjs.com/package/tw-animate-css Shadcn is using this in the latest Tailwind v4 version. |
|
Hi @ariflogs, it should be working now. I’ve added the tw-animate-css library and updated the accordion classes for the opening and collapsing animations. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary by CodeRabbit
New Features
Style
Chores