Skip to content

Fixed serialization for iterable payload #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Jul 4, 2017
Merged

Fixed serialization for iterable payload #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8a459
Fixed serialization for iterable payload
Jul 3, 2017
4a2a1be
Payload serialization for iterable non BaseDto inherited objects
Jul 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion api_commons/dto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
# TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
# SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

from collections import Iterable
from django.conf import settings
from rest_framework.fields import empty, Field
from rest_framework.serializers import Serializer
Expand Down Expand Up @@ -95,6 +95,8 @@ def to_dict(self):
serialized_payload = self.payload
if isinstance(self.payload, BaseDto):
serialized_payload = self.payload.to_representation(self.payload)
if isinstance(self.payload, Iterable):
serialized_payload = list([(p.to_representation(p) if isinstance(p, BaseDto) else p) for p in self.payload])
return {
"payload": serialized_payload,
"service": self.service.to_dict()
Expand Down