Skip to content

Conversation

@Akash-Patil
Copy link
Contributor

Checklist

Please note that in case of below checklist not updated accordingly, the maintainers have the right to immediately close your pull request.

  • You created a branch from develop branch.
  • You PR is raised on develop branch and not onmain.
  • You have read the Contribution Guidlines before creating this PR.

Description of the Change

  • Added new command login-method with get,add,delete actions. This command only works for Developer Pro Plans.
  • Updated files in api package to provide support for the same.

Risk Impact

  • Low

Verification Process

Tested following commands in CLI with edge cases:

- lr add login-method
- lr delete login-method
- lr get login-method
- lr demo

Release Notes

  • Added get,add,delete login-method commands.

@Akash-Patil Akash-Patil changed the title Added advanced Login methods commands Added advanced Login method commands Jul 19, 2021
Copy link
Collaborator

@mohammed786 mohammed786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mohammed786 mohammed786 merged commit 45d7f7e into LoginRadius:develop Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants