Getting error when options set for a field

[rajeev-k-tomy]

Problem

In the form layout xml file, when the options are set for a field as shown in the example,

<item name="is_active" xsi:type="array">
    <item name="field_type" xsi:type="string">select</item>
    <item name="sort_order" xsi:type="number">1</item>
    <item name="options" xsi:type="string">Magento\Config\Model\Config\Source\Yesno</item>
</item>

getting an error in the frontend like:

$options is not a proper instance: string

When I tried below:

    <item name="options" xsi:type="object">Magento\Config\Model\Config\Source\Yesno</item>

getting a different error in that case:

Instance of Magento\Framework\View\Element\Block\ArgumentInterface is expected, got Magento\Config\Model\Config\Source\Yesno instead.

---

Technical Details

Error is thrown from view/adminhtml/templates/form/field_type/select.phtml

$options = $field->getOptions();
...
if (false === $options instanceof OptionSourceInterface) {
    echo '$options is not a proper instance: '.gettype($options);
    return;
}

It seems $options is not resolved here.

---

[rajeev-k-tomy]

Proposal

In the Select field type class, I added below methods:

   private ?Field $field = null;

    public function __construct(
        private readonly ObjectManagerInterface $objectManager,
    ) {
    }

    public function setField(Field $field): self
    {
        $this->field = $field;
        return $this;
    }

    public function getOptions(): array
    {
        if (!$this->field) {
            return [];
        }

        $options = $this->field->getOptions();

        if (!$options) {
            return [];
        }

        $options  = $this->objectManager->get($options);

        if (!$options instanceof OptionSourceInterface) {
            return [];
        }

        return $options->toOptionArray();
    }

then in the select.phtml file:

$fieldType = $field->getFieldType()->setField($field);
$options = $fieldType->getOptions();

This way the responsibility to retrieve options belong to the field type Select. However, calling the setField() method each time from the template file does not feel right. I think this should be ideally done in the Field class:

public function getFieldType(): FieldTypeInterface
    {
        return $this->getData('field_type')->setField($this);
    }

But for this the contract FieldTypeInterface needs to update with setField() method.