Enable filters & searchable fields for the array grid provider#5
Merged
jissereitsma merged 2 commits intoLokiExtensions:masterfrom Jan 6, 2026
Merged
Enable filters & searchable fields for the array grid provider#5jissereitsma merged 2 commits intoLokiExtensions:masterfrom
jissereitsma merged 2 commits intoLokiExtensions:masterfrom
Conversation
Contributor
|
Very nice! I simple didn't get to this functionality yet. And I have to say that I didn't have a clear vision at the time how this could be best implemented, mostly because ArrayProviders lack features like performance-friendly pagination. But anyway, this PR is awesome! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
I've tested these in the module I'm building here: https://github.com/LBannenberg/magento2-composer-dashboard, although I had to twist the from_to a bit because I'm not using that directly.
I didn't have a clear example of the 'in' condition type being used, it seemed like you might want to use it for a multiselect situation (customer groups, stores)? Without a good example of it in action, I haven't implemented that, so you'd safely fall through to the default case (line 99).