Skip to content

Replace usage of Objects.equals (old Android support)#6

Merged
Longi94 merged 2 commits intoLongi94:masterfrom
steevp:master
Mar 21, 2018
Merged

Replace usage of Objects.equals (old Android support)#6
Longi94 merged 2 commits intoLongi94:masterfrom
steevp:master

Conversation

@steevp
Copy link
Copy Markdown
Contributor

@steevp steevp commented Mar 21, 2018

Description

Android didn't add support for the Objects class until API level 19 (KitKat). This PR simply uses a compat class that does the same thing.

Checklist

  • Code compiles correctly
  • All tests passing
  • Samples run successfully
  • Extended the README / documentation, if necessary

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2018

Codecov Report

Merging #6 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #6      +/-   ##
============================================
+ Coverage      21.5%   21.51%   +<.01%     
- Complexity      413      417       +4     
============================================
  Files           181      182       +1     
  Lines          5844     5846       +2     
  Branches        484      484              
============================================
+ Hits           1257     1258       +1     
- Misses         4416     4417       +1     
  Partials        171      171
Impacted Files Coverage Δ Complexity Δ
...main/java/in/dragonbra/javasteam/types/GameID.java 15.21% <0%> (ø) 3 <0> (ø) ⬇️
...a/in/dragonbra/javasteam/util/CollectionUtils.java 50% <100%> (ø) 2 <0> (ø) ⬇️
...in/java/in/dragonbra/javasteam/types/GlobalID.java 20.68% <100%> (ø) 3 <0> (ø) ⬇️
...ain/java/in/dragonbra/javasteam/types/SteamID.java 76.57% <100%> (ø) 50 <0> (ø) ⬇️
...dragonbra/javasteam/util/compat/ObjectsCompat.java 50% <50%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8706971...5e68ba4. Read the comment docs.

@Longi94 Longi94 merged commit 34643e7 into Longi94:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants