Skip to content

fix: issue 122#126

Merged
AngRodrigues merged 2 commits intomasterfrom
fix/strati_column_extra_units
Aug 9, 2024
Merged

fix: issue 122#126
AngRodrigues merged 2 commits intomasterfrom
fix/strati_column_extra_units

Conversation

@AngRodrigues
Copy link
Member

Description

Intrusives are usually removed from the geology file (if the config file allows).
if a strati measurement falls into an intrusive, it cannot be used to measure thickness.
This fix removes measurements that fall into empty geology.

Also added check to skip units that are not in the geology map.

Fixes #122

Type of change

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Test improvement

How Has This Been Tested?

Please describe any tests that you ran to verify your changes.
Provide branch name so we can reproduce.

Tested with code given in issue #122 & branch fix/strati_column_extra_units

Checklist:

  • This branch is up-to-date with master
  • All gh-action checks are passing
  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My tests run with pytest from the map2loop folder
  • New and existing tests pass locally with my changes

Checklist continued (if PR includes changes to documentation)

  • I have built the documentation locally with make.bat
  • I have built this documentation in docker, following the docker configuration in map2loop/docs
  • I have checked my spelling and grammar

Copy link
Member

@lachlangrose lachlangrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but change the strings to use string formatting to make it easier to port to use the logging class.

@AngRodrigues AngRodrigues merged commit 796b90b into master Aug 9, 2024
@AngRodrigues AngRodrigues deleted the fix/strati_column_extra_units branch August 9, 2024 02:21
noellehmcheng pushed a commit that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] - structured point fails when unit name is not on map

2 participants