Merged
Conversation
lachlangrose
approved these changes
Aug 9, 2024
Member
lachlangrose
left a comment
There was a problem hiding this comment.
Looks fine, but change the strings to use string formatting to make it easier to port to use the logging class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Intrusives are usually removed from the geology file (if the config file allows).
if a strati measurement falls into an intrusive, it cannot be used to measure thickness.
This fix removes measurements that fall into empty geology.
Also added check to skip units that are not in the geology map.
Fixes #122
Type of change
How Has This Been Tested?
Please describe any tests that you ran to verify your changes.
Provide branch name so we can reproduce.
Tested with code given in issue #122 & branch fix/strati_column_extra_units
Checklist:
Checklist continued (if PR includes changes to documentation)