Filter out future-dated sensor events#191
Merged
ps2 merged 2 commits intoLoopKit:devfrom May 19, 2024
Merged
Conversation
Contributor
|
The person who tested this uses G6 sensors with Loop-dev.
After applying the code from this PR, a new sensor was started and the SAGE pill was populated without needing to remove future dates from Nightscout.
|
Contributor
|
@ps2 Please respond. This is a work-around for the root cause, but it does work to provide SAGE correctly for Loop users with Nightscout. |
ps2
requested changes
May 19, 2024
| } | ||
|
|
||
| // Filter out future-dated events | ||
| events = events.filter { event in |
Contributor
There was a problem hiding this comment.
This is not fixing the underlying problem (incorrect parsing of message data earlier in the process). Please add a comment that this is a stopgap fix for the issue (LoopKit/Loop#2087) and add an error level log here that includes a string description of the glucose object.
ps2
approved these changes
May 19, 2024
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a filter in TransmitterManager to exclude future-dated sensor events before sending to Nightscout. The solution has been successfully tested with a real sensor.
Resolves LoopKit/Loop#2087