Skip to content

Conversation

@dabear
Copy link
Contributor

@dabear dabear commented Feb 24, 2020

Issue reported on zulipchat: https://loop.zulipchat.com/#narrow/stream/144182-development/topic/trend.20arrow.20inconsistency

The code for uploading to nightscout has been inside Loop for a very long time, but has up to now only been used by the medtronic enlite cgmmanager. Now that the Dexcom cgmmanager also can upload to loop, more users have started using this feature.

I've detected that the loop trend arrow doesn't always match the trend arrow displayed in nightscout. This fixes that by uploading the correct trend arrow names, adding those that were lacking from the original implementation.

(My guess is that Loop's code for uploading glucose trend arrows predates nightscout's support for granular trend arrows. This code should be safe because Nightscout users generally update fast and because nightscout has supported granular trend arrows for a long time now, meaning the risk here is quite low.)

@dabear
Copy link
Contributor Author

dabear commented Feb 24, 2020

On the nightscout repo, see which trend arrows are supported here: https://github.com/nightscout/cgm-remote-monitor/blob/7c272ec67a7795e0f4edf7ff9abdfac1bd1308a0/tests/direction.test.js#L69

@dabear
Copy link
Contributor Author

dabear commented Feb 25, 2020

@ps2 this is a small change. Tested successfully. Should be ready to merge

@ps2 ps2 merged commit ed7bf7f into LoopKit:dev Feb 25, 2020
mitchellhenke pushed a commit to mitchellhenke/Loop that referenced this pull request Apr 12, 2020
mitchellhenke pushed a commit to mitchellhenke/Loop that referenced this pull request Apr 12, 2020
@pakritz
Copy link

pakritz commented Jul 25, 2020

We have Loop Master Branch 2.0. We started looping in March and have not added any features or changed branches. We have Loop Master 2.0/Ominpod/Dexcom G6/iPhone 11 Pro iOS 13.4.1. I am not a technical person and make a very honest effort to watch Kate's Youtube videos and search groups to find information as well as other FB groups that post helpful videos. The learning curve is steep but I am determined. I would greatly appreciate input or direction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants