My customized loop setup fix#763
Closed
chadharper0131 wants to merge 77 commits into
Closed
Conversation
Adds integral action to retrospective correction
integral retrospective correction, safer velocity calculation
integral retrospective correct, reset if glucose data missing
…trospective-correction
…e-correction-restart
…tart Integral retrospective correction restart
* Update to LoopKit v2 * Update to RLKit frameworks v2.0.2
* Remove boilerplate comments * Remove boilerplate comments and methods
…e-correction-LoopKit2 # Conflicts: # Common/Models/LoopSettings.swift # Loop/Managers/AnalyticsManager.swift # Loop/Managers/LoopDataManager.swift # Loop/View Controllers/PredictionTableViewController.swift
…pKit2 Align with Loop updates around LoopKit v2
# Conflicts: # Loop.xcconfig # Loop.xcodeproj/project.pbxproj
This technically isn't necessary as they are updated in the same function but for consistency and not to forget during the next refactoring this is protecting the user from getting a potentially dangerous out of date recommendation.
* Build dependencies on the fly * Build dependencies first, without xcpretty * update travis to use Xcode 9.4
* Implement PumpManager protocol * Use LoopKit and RlKit dev
previously was using 75% of the pickerValue also remove the extra casting
# Conflicts: # Loop.xcodeproj/project.pbxproj
Collaborator
|
I am guessing you didn’t mean to do this PR? |
Collaborator
|
I’ll go ahead and close it out |
loopkitdev
pushed a commit
to loopkitdev/Loop
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.