Skip to content

Update dev to 3.14.2 #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marionbarker wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Update dev to 3.14.2 #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ad21c1
Bump version to 3.14.2
marionbarker May 29, 2026
488c57a
update Loop: warn if on dev, support OmnipodKit
marionbarker May 29, 2026
b27af62
update OmniBLE: fix identifier for 17e for Pod Keep Alive
marionbarker May 29, 2026
e18ef9a
update GitHub action to use Xcode 26.4
marionbarker May 30, 2026
4cf9e34
update to fastlane 2.335.0
marionbarker May 30, 2026
a61dab4
add submodule OmnipodKit:
marionbarker Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_loop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ jobs:
(vars.SCHEDULED_SYNC != 'false' && needs.check_status.outputs.NEW_COMMITS == 'true' )
steps:
- name: Select Xcode version
run: "sudo xcode-select --switch /Applications/Xcode_26.2.app/Contents/Developer"
run: "sudo xcode-select --switch /Applications/Xcode_26.4.app/Contents/Developer"

- name: Checkout Repo for building
uses: actions/checkout@v5
Expand Down
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,6 @@
[submodule "LibreTransmitter"]
path = LibreTransmitter
url = https://github.com/LoopKit/LibreTransmitter.git
[submodule "OmnipodKit"]
path = OmnipodKit
url = https://github.com/loopandlearn/OmnipodKit
Copy link
Copy Markdown
Contributor

@ps2 ps2 Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer all the core device integrations for DIY Loop to remain in LoopKit. If there's some strong reason not to host it locally, let me know.

Copy link
Copy Markdown
Contributor

@ps2 ps2 Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I don't think we should be punting the decision of which driver set to use (omnikit/omnible vs omnipodkit) to the user. That adds complexity for the user, for documentation, etc. When the new package is ready, it should be the integration for omnipod, and the old ones removed. I saw there is some automigration on the Loop side, which is nice.

Copy link
Copy Markdown
Contributor

@ps2 ps2 Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized maybe my second point was already the plan. I think that's good; just would prefer that kind of unfinished business to stay on dev, and not be in a release.

Copy link
Copy Markdown
Contributor Author

@marionbarker marionbarker Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding hosting of new managers - we have OmnipodKit pump manager plus others that we want to support in Loop. They are coming from other repositories:
e.g.

    bastiaanv:DanaKit:dev \
    bastiaanv:EversenseKit:dev \
    jbr7rr:MedtrumKit:dev \
    loopandlearn:OmnipodKit:main \

with at least one more to come that is private at this time.

We could set up forks within LoopKit for those repositories, and could set up scripts to keep them up to date with the upstream repositories.

Copy link
Copy Markdown
Contributor Author

@marionbarker marionbarker Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the proposed configuration for dev and main 3.14.2, this is a temporary situation that is leading to having only OmnipodKit in feature branches, in the incoming tidepool-sync and in future releases.

This is why we need a main and dev version with all three pump managers before we make available a branch with only OmnipodKit.

  • If someone builds a feature branch that has only OmnipodKit, their current pod is converted to the OmnipodKit manager automatically
  • If that same person then builds a version of main or dev that does not have OmnipodKit, they lose control of their pod
  • We have tested this scenario and if the user follows up by building the feature branch again, communication is restored
  • However, we want to protect against someone trying a feature branch and then deciding that branch is not ready yet
  • By having all 3 managers in main and dev, we can transition safely
    • Users can decide to test out the new OmnipodKit by changing between pods while still in main or dev
    • Users can back up from a feature branch to main and dev and still have OmnipodKit available

We expect to move quickly to the next version where only OmnipodKit is provided, but we want to enable a wider pool of testers before forcing people to move to the new manager.

Copy link
Copy Markdown
Contributor

@ps2 ps2 Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good setup for dev, and not actually have a release, if we're not confident for release.

2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
source "https://rubygems.org"
gem "fastlane", "2.234.0"
gem "fastlane", "2.235.0"
12 changes: 6 additions & 6 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ GEM
faraday_middleware (1.2.1)
faraday (~> 1.0)
fastimage (2.4.0)
fastlane (2.234.0)
fastlane (2.235.0)
CFPropertyList (>= 2.3, < 5.0.0)
abbrev (~> 0.1)
addressable (>= 2.8, < 3.0.0)
Expand All @@ -81,7 +81,7 @@ GEM
babosa (>= 1.0.3, < 2.0.0)
base64 (~> 0.2)
benchmark (>= 0.1.0)
bundler (>= 1.17.3, < 5.0.0)
bundler (>= 2.4.0, < 5.0.0)
colored (~> 1.2)
commander (~> 4.6)
csv (~> 3.3)
Expand All @@ -96,12 +96,12 @@ GEM
gh_inspector (>= 1.1.2, < 2.0.0)
google-apis-androidpublisher_v3 (~> 0.3)
google-apis-playcustomapp_v1 (~> 0.1)
google-cloud-env (>= 1.6.0, <= 2.1.1)
google-cloud-env (>= 1.6.0, < 2.3.0)
google-cloud-storage (~> 1.31)
highline (~> 2.0)
http-cookie (~> 1.0.5)
json (< 3.0.0)
jwt (>= 2.1.0, < 3)
jwt (>= 2.1.0, < 4)
logger (>= 1.6, < 2.0)
mini_magick (>= 4.9.4, < 5.0.0)
multipart-post (>= 2.0.0, < 3.0.0)
Expand Down Expand Up @@ -230,7 +230,7 @@ PLATFORMS
ruby

DEPENDENCIES
fastlane (= 2.234.0)
fastlane (= 2.235.0)

BUNDLED WITH
4.0.6
4.0.12
2 changes: 1 addition & 1 deletion Loop
Open in desktop
Submodule Loop updated 1 files
+12 −1 Loop/Managers/DeviceDataManager.swift
3 changes: 3 additions & 0 deletions LoopWorkspace.xcworkspace/contents.xcworkspacedata
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 24 additions & 0 deletions LoopWorkspace.xcworkspace/xcshareddata/xcschemes/LoopWorkspace.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,20 @@
ReferencedContainer = "container:MinimedKit/MinimedKit.xcodeproj">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "YES"
buildForArchiving = "YES"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "D889B2382D2B4BFE00C8E64C"
BuildableName = "OmnipodKitPlugin.loopplugin"
BlueprintName = "OmnipodKitPlugin"
ReferencedContainer = "container:OmnipodKit/OmnipodKit.xcodeproj">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
Expand Down Expand Up @@ -539,6 +553,16 @@
ReferencedContainer = "container:RileyLinkKit/RileyLinkKit.xcodeproj">
</BuildableReference>
</TestableReference>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "D8D0ED172D74EF41000B0AF4"
BuildableName = "OmniTests.xctest"
BlueprintName = "OmniTests"
ReferencedContainer = "container:OmnipodKit/OmnipodKit.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
</TestAction>
<LaunchAction
Expand Down
2 changes: 1 addition & 1 deletion OmniBLE
Open in desktop
Submodule OmniBLE updated 1 files
+2 −2 OmniBLE/PumpManager/OmniBLEPumpManager.swift
1 change: 1 addition & 0 deletions OmnipodKit
Open in desktop
Submodule OmnipodKit added at c04c4d
4 changes: 2 additions & 2 deletions Scripts/define_common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ MESSAGE_FILE="xlate_message_file.txt"
# matches lokalise order, en plus alphabetical order by language name in English
LANGUAGES=(en \
ar \
ce \
zh-Hans \
cs \
da \
Expand All @@ -43,10 +42,10 @@ LANGUAGES=(en \
fr \
de \
he \
hi \
hu \
it \
ja \
ko \
nb \
pl \
pt-BR \
Expand Down Expand Up @@ -79,6 +78,7 @@ PROJECTS=( \
LoopKit:OmniKit:main \
LoopKit:RileyLinkKit:dev \
LoopKit:TidepoolService:dev \
loopandlearn:OmnipodKit:main \
)

function section_divider() {
Expand Down
2 changes: 1 addition & 1 deletion VersionOverride.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@

// Version [for DIY Loop]
// configure the version number in LoopWorkspace
LOOP_MARKETING_VERSION = 3.14.1
LOOP_MARKETING_VERSION = 3.14.2
CURRENT_PROJECT_VERSION = 57