Tidepool sync 2026-05-11#169
Open
loopkitdev wants to merge 50 commits into
Open
Conversation
…t-store LOOP-4735 CGM Event Store
…t-store LOOP-4735 CGM Event Store
* adding pump inoperable * fault returns pumpInoperable
* adding pump inoperable * fault returns pumpInoperable
…scheduled-presets LOOP-5235 Enable scheduled presets
…scheduled-presets LOOP-5235 Enable scheduled presets
Pass lastPumpDataReportDate as a parameter instead of accessing state inside isSignalLost(), which caused recursive lock acquisition and an EXC_BREAKPOINT crash when called from within a lockedState.mutate closure. Ports the same fix applied to OmniKit in 924f10d.
Resolved source + pbxproj conflicts. Source resolutions: - OmniBLEPumpManager.swift: kept DIY for 3 regions (reentrant lock fix from commit e9425ad); region at line 2221 kept DIY (setTempBasal switch with completion(.communication(error)) errors — Tidepool's do/catch refactor cannot be cleanly applied without replacing the whole function, decisionId tracking already present); region at line 2722 manual merge (preserved DIY suspend-time-expired alert special case from Pod Keep Alive LoopKit#165 and adopted Tidepool's properly-indented try await withCheckedThrowingContinuation); 3 regions took Tidepool (mutateState Swift 6 API migration). pbxproj: only conflicts were preserving LOCALIZATION_PREFERS_STRING_CATALOGS in Debug/Release configs (rule 5). No source-file refs in conflict.
Same regression as OmniKit. OmniBLEPumpManager defines only setState (line 176); 3 mutateState calls from the sync conflict resolution failed to compile. Reverted to setState; matches the 48 other call sites.
This was referenced May 20, 2026
Closed
Emit a NewPumpEvent (.alarm) when a pod fault is first detected so the fault is persisted to the pump event store and uploaded to remote services (e.g. Nightscout), mirroring the existing Pod Change event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshed Tidepool → DIY sync from the
tidepool-sync/2026-05-11branch.This supersedes and replaces the previous Tidepool Merge PR (#133), which is being closed in favor of this one.