Fixes for various subtle resume and suspend events issues #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
itsmojo
commented
Nov 11, 2025
itsmojo
commented
- Remove incorrect resume event creation in programInitialBasalSchedule()
- Finalize resume & suspend "doses" independently on matching delivery status
- Update dosesToStore var to no longer include now unneeded unfinalizedSuspend
- Use date instead of Date() in updateDeliveryStatus() for consistency
- Use self.lastSync instead of lastSync for better clarity & consistency
- Update basalDeliveryState to treat a non-active pod just like no pod
+ Remove incorrect resume event creation in programInitialBasalSchedule() + Finalize resume & suspend "doses" independently on matching delivery status + Update dosesToStore var to no longer include now unneeded unfinalizedSuspend + Use date instead of Date() in updateDeliveryStatus() for consistency + Use self.lastSync instead of lastSync for better clarity & consistency + Update basalDeliveryState to treat a non-active pod just like no pod
marionbarker
approved these changes
Nov 19, 2025
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Approve from code review. These changes were tested in the parallel OmniBLE PR 154.
The changes were compared side-by-side and are identical between OmniKit and OmniBLE.
The Loop app was built with both OmniBLE PR 154 and OmniKit PR 61 versions of code.
- There was no problem with the build and the OmniKit pump could be selected.
The Trio app (0.6.0.11) was built with both OmniBLE PR 154 and OmniKit PR 61 versions of code.
- There was no problem with the build and the OmniKit pump could be selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.