-
Notifications
You must be signed in to change notification settings - Fork 1
[feat] Add Sparkle #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>com.apple.security.temporary-exception.mach-lookup.global-name</key> | ||
| <array> | ||
| <string>$(PRODUCT_BUNDLE_IDENTIFIER)-spks</string> | ||
| <string>$(PRODUCT_BUNDLE_IDENTIFIER)-spki</string> | ||
| </array> | ||
| </dict> | ||
| </plist> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>SUEnableInstallerLauncherService</key> | ||
| <true/> | ||
| <key>SUFeedURL</key> | ||
| <string>https://loopingstudio.github.io/ApertureTokenManager/appcast.xml</string> | ||
| <key>SUPublicEDKey</key> | ||
| <string>AO8KvH4ISg6LNcdRlUJCjRYzHasX7GEhSPee9Y8GA8I=</string> | ||
| </dict> | ||
| </plist> | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,22 @@ | ||||||
| <?xml version="1.0" standalone="yes"?> | ||||||
| <rss xmlns:sparkle="http://www.andymatuschak.org/xml-namespaces/sparkle" version="2.0"> | ||||||
| <channel> | ||||||
| <title>ApertureTokensManager</title> | ||||||
| <item> | ||||||
| <title>1.0.1</title> | ||||||
| <pubDate>Fri, 16 Feb 2026 10:19:35 +0100</pubDate> | ||||||
| <sparkle:version>1</sparkle:version> | ||||||
|
||||||
| <sparkle:version>1</sparkle:version> | |
| <sparkle:version>2</sparkle:version> |
Copilot
AI
Feb 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minimum system version is set to 15.0, but this should be aligned with the actual deployment target. The Xcode project sets MACOSX_DEPLOYMENT_TARGET = 15.0, so this is consistent. However, ensure that Sparkle 2.8.1 supports macOS 15.0 as the minimum version.
Copilot
AI
Feb 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra space before the exclamation mark in "the app !". In English, punctuation should typically be placed directly after the last word without a preceding space.
| <li>Enjoy the first version of the app !</li> | |
| <li>Enjoy the first version of the app!</li> |
Copilot
AI
Feb 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release notes describe this as the "Initial release" which is inconsistent with the version number 1.0.1. An initial release should typically be version 1.0.0, or if this is version 1.0.1, the release notes should describe what's new in this update compared to 1.0.0.
Copilot
AI
Feb 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The enclosure URL points to a GitHub release (1.0.1) that may not exist yet if this is the initial release adding Sparkle functionality. Ensure the release is created and the ZIP file is uploaded to GitHub releases before this version is distributed, otherwise update checks will fail.
Copilot
AI
Feb 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The enclosure element is missing the required sparkle:version attribute. According to Sparkle 2.x documentation, the enclosure tag should include sparkle:version to specify the build number for the update package.
| <enclosure url="https://github.com/LoopingStudio/ApertureTokenManager/releases/download/1.0.1/ApertureTokensManager.zip" length="7253356" type="application/octet-stream" sparkle:edSignature="pPTbrV1VW8MjuWMyeQxQh8MsYUYOaiX/qTw8WFdjmE1nzTgUy3QirBKVPenqXDifibe5BhosHD6XFsRvkn0xCQ=="/> | |
| <enclosure url="https://github.com/LoopingStudio/ApertureTokenManager/releases/download/1.0.1/ApertureTokensManager.zip" length="7253356" type="application/octet-stream" sparkle:version="1" sparkle:edSignature="pPTbrV1VW8MjuWMyeQxQh8MsYUYOaiX/qTw8WFdjmE1nzTgUy3QirBKVPenqXDifibe5BhosHD6XFsRvkn0xCQ=="/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URLs use "ApertureTokenManager" (without 's') while the app is named "ApertureTokensManager" (with 's'). Ensure that the GitHub repository name is actually "ApertureTokenManager" and that GitHub Pages is correctly configured at this URL, otherwise update checks will fail.