fix(cli): update traceability tests to use relationships instead of links#136
Merged
fix(cli): update traceability tests to use relationships instead of links#136
Conversation
…inks Agent-Logs-Url: https://github.com/Looted/kibi/sessions/500a899d-ebca-4591-84aa-7f23f24f2f22 Co-authored-by: Looted <6255880+Looted@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Looted
April 6, 2026 10:37
View session
There was a problem hiding this comment.
Pull request overview
This PR updates CLI traceability tests to match the current ManifestLookupEntry shape on develop, replacing the legacy links: string[] fixtures with relationships: { type, to }[] so the manifest lookup data is consumed correctly by symbol-extract.
Changes:
- Updated 3
ManifestLookuptest fixtures to userelationshipsentries ({ type: "implements", to: "..." }) instead oflinks. - Aligns traceability tests with the
developbranch’sManifestLookupEntry.relationshipsbehavior, fixing CI failures from themain→developmerge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 2 failing CI tests introduced by the
main→developmerge.Root Cause
The merge commit (
0a58c1e) broughtpackages/cli/tests/traceability/traceability.test.tsfrommain. This test file was written against the olderManifestLookupEntryinterface that usedlinks?: string[]. However, thedevelopbranch had independently evolvedsymbol-extract.tsto use a richerrelationships?: TraceabilityRelationship[]interface instead.This caused a runtime mismatch: the tests passed
{ id: "...", links: [...] }entries to the manifest lookup, but the source code looked forentry.relationships(which wasundefined), resulting in emptyreqLinksarrays.Failing Tests Fixed
symbol-extract > uses manifest lookup ID when symbol matches sourceFile:titlesymbol-extract > manifest lookup distinguishes symbols by sourceFile not just titleA third test (
inline directive links take precedence over manifest links) was also using the wronglinksformat but happened to pass because the inline directive overrides manifest links anyway — it was also updated for correctness.Changes
packages/cli/tests/traceability/traceability.test.ts: Replacelinks: string[]withrelationships: TraceabilityRelationship[]({ type: "implements", to: "..." }) in 3 testManifestLookupfixtures to match the currentManifestLookupEntryinterface.