Fix minor issues by Looted · Pull Request #38 · Looted/kibi

Looted · 2026-03-02T09:08:01Z

No description provided.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 492e1cc760

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T09:10:55Z

  "dependencies": {
-    "@modelcontextprotocol/sdk": "^1.26.0",
-    "ajv": "^8.18.0",
-    "cli-table3": "^0.6.5",
-    "commander": "^11.0.0",
-    "fast-glob": "^3.2.12",
-    "gray-matter": "^4.0.3",
+    "kibi-cli": "^0.1.5",
+    "@modelcontextprotocol/sdk": "^1.14.0",
+    "ajv": "^8.17.1",
    "js-yaml": "^4.1.0",
-    "kibi-core": "^0.1.5",
-    "mcpcat": "^0.1.12",
-    "ts-morph": "^23.0.0",
-    "zod": "^4.3.6"
+    "zod": "^3.25.7"
  },


Restore mcpcat as a declared dependency

kibi-mcp still has a static import of mcpcat in packages/mcp/src/mcpcat.ts:51, so removing mcpcat from this package’s dependency list means fresh installs of kibi-mcp (outside this monorepo/hoisted node_modules) can fail at process startup with ERR_MODULE_NOT_FOUND before any tool logic runs. Because the import is unconditional, this affects all runtime contexts, not only analytics-enabled ones.

Useful? React with 👍 / 👎.

Copilot

Pull request overview

This PR updates the MCP and CLI packages to reduce/adjust dependencies and fix issues in the CLI’s relationship querying behavior.

Changes:

Simplifies packages/mcp dependencies and adjusts npm lifecycle script/exports.
Fixes kibi query --relationships to correctly parse [Type,From,To] results and adds basic input escaping.
Tweaks packages/cli packaging config (formatting + adds prepack build hook).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
packages/mcp/package.json	Removes/changes dependencies, swaps publish hook to `prepack`, and narrows exports.
packages/cli/src/commands/query.ts	Reworks relationship querying goal + result parsing for relationships mode.
packages/cli/package.json	Re-formats `files` and adds `prepack` alongside `prepublishOnly`.

Copilot · 2026-03-02T09:13:10Z

+      // Keep in sync with relationship.schema.json
+      const REL_TYPES = [
+        "depends_on",
+        "specified_by",
+        "verified_by",
+        "validates",
+        "implements",
+        "covered_by",
+        "constrained_by",
+        "constrains",
+        "requires_property",
+        "guards",
+        "publishes",
+        "consumes",
+        "supersedes",
+        "relates_to",
+      ] as const;
+
+      const relTypeList = `[${REL_TYPES.join(",")}]`;
+      const goal = `findall([Type,From,To], (From='${safeFromId}', member(Type, ${relTypeList}), kb_relationship(Type, From, To)), Results)`;
+


REL_TYPES duplicates the relationship type enum from src/schemas/relationship.schema.json (and the generated src/public/schemas/relationship.ts). To avoid drift, consider deriving this list from the existing schema export (e.g., reading relationshipSchema.properties.type.enum) instead of maintaining a separate hard-coded array.

Suggested change

// Keep in sync with relationship.schema.json

const REL_TYPES = [

"depends_on",

"specified_by",

"verified_by",

"validates",

"implements",

"covered_by",

"constrained_by",

"constrains",

"requires_property",

"guards",

"publishes",

"consumes",

"supersedes",

"relates_to",

] as const;

const relTypeList = `[${REL_TYPES.join(",")}]`;

const goal = `findall([Type,From,To], (From='${safeFromId}', member(Type, ${relTypeList}), kb_relationship(Type, From, To)), Results)`;

// Query all relationship types for the given source ID

const goal = `findall([Type,From,To], (From='${safeFromId}', kb_relationship(Type, From, To)), Results)`;

Copilot · 2026-03-02T09:13:11Z

+        results = rows
+          .filter((r) => r.length >= 3)
+          .map((r) => ({
+            type: parsePrologValue(r[0]),
+            from: parsePrologValue(r[1]),
+            to: parsePrologValue(r[2]),
+          }));


The existing kibi query relationships test only asserts that JSON output is an array; it won’t catch regressions in the updated [Type,From,To] parsing/escaping logic introduced here. Consider strengthening the test to assert the returned objects have type/from/to fields (and ideally that from matches the queried id and type is one of the allowed relationship types).

Suggested change

results = rows

.filter((r) => r.length >= 3)

.map((r) => ({

type: parsePrologValue(r[0]),

from: parsePrologValue(r[1]),

to: parsePrologValue(r[2]),

}));

const parsed = rows

.filter((r) => r.length >= 3)

.map((r) => ({

type: parsePrologValue(r[0]),

from: parsePrologValue(r[1]),

to: parsePrologValue(r[2]),

}));

results = parsed.filter(

(rel) =>

rel &&

typeof rel.type === "string" &&

typeof rel.from === "string" &&

typeof rel.to === "string" &&

rel.from === fromId &&

// Ensure the relationship type is one of the allowed Prolog types

// (kept in sync with relationship.schema.json via REL_TYPES).

(REL_TYPES as readonly string[]).includes(rel.type),

);

Copilot · 2026-03-02T09:13:11Z

+    "kibi-cli": "^0.1.5",
+    "@modelcontextprotocol/sdk": "^1.14.0",
+    "ajv": "^8.17.1",
    "js-yaml": "^4.1.0",


mcpcat was removed from dependencies, but the MCP server still imports it (packages/mcp/src/mcpcat.ts uses import * as mcpcat from "mcpcat"). This will cause runtime/packaging failures unless mcpcat is added back as a direct dependency (or the import is made optional via a guarded dynamic import).

Suggested change

"js-yaml": "^4.1.0",

"js-yaml": "^4.1.0",

"mcpcat": "^0.1.0",

Copilot · 2026-03-02T09:13:11Z

  "scripts": {
    "build": "tsc -p tsconfig.json",
-    "prepublishOnly": "npm run build"
+    "prepublishOnly": "npm run build",


Both prepublishOnly and prepack run npm run build. On npm publish, this typically causes the build to run twice (since prepack runs on both npm pack and npm publish, and prepublishOnly runs on publish). Consider keeping only one of these hooks to avoid redundant work (matching what packages/mcp does).

Suggested change

"prepublishOnly": "npm run build",

- Restore all original dependencies that were incorrectly removed - Add kibi-cli as explicit dependency (needed for imports) - Add prepack script to ensure dist is rebuilt before publish - Remove broken ./src/* export that pointed to non-existent files Fixes build errors caused by missing mcpcat, ts-morph, and other deps

Looted · 2026-03-02T09:31:23Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-03-02T09:31:30Z

@Looted I've opened a new pull request, #39, to work on those changes. Once the pull request is ready, I'll request review from you.

…engthen test, remove duplicate build hooks Co-authored-by: Looted <6255880+Looted@users.noreply.github.com>

refactor(cli): derive REL_TYPES from schema, strengthen relationship query validation

Fix minor issues

492e1cc

Copilot AI review requested due to automatic review settings March 2, 2026 09:08

Copilot started reviewing on behalf of Looted March 2, 2026 09:08 View session

chatgpt-codex-connector Bot reviewed Mar 2, 2026

View reviewed changes

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Initial plan

464e11c

Copilot AI mentioned this pull request Mar 2, 2026

refactor(cli): derive REL_TYPES from schema, strengthen relationship query validation #39

Merged

Copilot AI and others added 2 commits March 2, 2026 09:38

refactor(cli): derive REL_TYPES from schema, simplify query goal, str…

8e3f3c0

…engthen test, remove duplicate build hooks Co-authored-by: Looted <6255880+Looted@users.noreply.github.com>

Merge pull request #39 from Looted/copilot/sub-pr-38

dc1a4a6

refactor(cli): derive REL_TYPES from schema, strengthen relationship query validation

Looted merged commit 56a81ee into master Mar 2, 2026
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix minor issues#38

Fix minor issues#38
Looted merged 5 commits intomasterfrom
develop

Looted commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Looted commented Mar 2, 2026

Uh oh!

Copilot AI commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Looted commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Looted commented Mar 2, 2026

Uh oh!

Copilot AI commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants