Conversation
The --test-timeout flag is not valid for bun test. Changed to --timeout to use the correct flag and set a 300-second (5-minute) timeout for all tests.
There was a problem hiding this comment.
Pull request overview
Updates CI to use Bun’s correct test timeout flag, aligning workflow execution with Bun’s CLI options and ensuring tests have a 5-minute cap.
Changes:
- Replaced
bun test --test-timeout=...withbun test --timeout=...in the CI unit-test step.
You can also share your feedback on Copilot code review. Take the survey.
| - name: Run unit tests | ||
| if: ${{ !inputs.skip_tests }} | ||
| run: bun test --test-timeout=300000 --exclude="documentation/tests/e2e/packed/**" | ||
| run: bun test --timeout=300000 --exclude="documentation/tests/e2e/packed/**" |
Contributor
Co-authored-by: Looted <6255880+Looted@users.noreply.github.com>
[WIP] [WIP] Address feedback on --timeout flag usage in bun test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --test-timeout flag is not valid for bun test. Changed to --timeout to use the correct flag and set a 300-second (5-minute) timeout for all tests.