Fix README structure, core CHANGELOG accuracy, and document JS tag filtering tradeoff#69
Merged
Fix README structure, core CHANGELOG accuracy, and document JS tag filtering tradeoff#69
Conversation
…ng TODO Co-authored-by: Looted <6255880+Looted@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update README and fix minor issues
Fix README structure, core CHANGELOG accuracy, and document JS tag filtering tradeoff
Mar 13, 2026
There was a problem hiding this comment.
Pull request overview
This PR cleans up project documentation and release notes to accurately reflect where behavior changes live (core vs MCP), and documents an important performance tradeoff in MCP query behavior.
Changes:
- Restructures README headings to fix markdown hierarchy and remove duplicate component listing.
- Corrects
kibi-core0.1.8 changelog entry to describe only the core Prolog predicate fix (kb_entities_by_source). - Adds an inline TODO documenting the current “fetch-all then filter in JS” cost for tag filtering in MCP queries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Fixes heading structure and removes duplicated/incorrect component listing. |
| packages/core/CHANGELOG.md | Updates 0.1.8 notes to match the actual core change (source lookup normalization). |
| packages/mcp/src/tools/query.ts | Documents the tag-filtering implementation tradeoff and future rework intent. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three issues flagged in review: README heading hierarchy was broken (Key Components rendered as a Prerequisites subsection with a duplicate kibi-core entry), the kibi-core 0.1.8 changelog incorrectly attributed MCP-layer tag filtering/dedup changes to the core package, and the JS-side tag filtering had no documentation of its performance tradeoff.
Changes
## Prerequisites; promoteKey Componentsto a top-level##section placed before Prerequisites; remove duplicatekibi-coreentry that appeared in both sectionskb_entities_by_sourcepredicate fix (source=normalization viasource_value_atom/2); remove incorrect mention of tag filtering/dedup which belongs tokibi-mcp📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.