Conversation
- Add concurrency guard to publish workflow to prevent concurrent runs - Use subshell for npm publish to ensure cwd doesn't drift on failure - Fix same issue in publish-selective.sh script This prevents the 'cd: packages/mcp: No such file or directory' error that occurred when a publish failed mid-chain and subsequent iterations tried to cd from the wrong directory.
There was a problem hiding this comment.
Pull request overview
This PR hardens the npm publishing automation to avoid working-directory drift across publish attempts and to reduce the likelihood of overlapping publish runs.
Changes:
- Run
npm publishfrom a subshell (both in CI and the local helper script) so a failed publish can’t leave the runner in the wrong directory. - Add a workflow-level
concurrencyblock to gate overlapping runs of the publish workflow. - Add a changeset for a
kibi-corepatch bump and refresh generated symbol coordinates.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scripts/publish-selective.sh |
Runs npm publish inside a subshell to prevent cwd drift if publish fails. |
.github/workflows/publish.yml |
Adds workflow concurrency gating and publishes each package from a subshell with an explicit workspace path. |
.changeset/core-patch-bump.md |
Introduces a patch bump changeset for kibi-core. |
documentation/symbols.yaml |
Updates generated symbol coordinate metadata/timestamps. |
You can also share your feedback on Copilot code review. Take the survey.
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} |
Comment on lines
+6
to
+9
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: false | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the 'cd: packages/mcp: No such file or directory' error that occurred when a publish failed mid-chain and subsequent iterations tried to cd from the wrong directory.