Skip to content

fix: YAML frontmatter indentation in E2E tests, event statuses, and legacy req status support#90

Merged
Looted merged 2 commits intodevelopfrom
copilot/sub-pr-89
Mar 19, 2026
Merged

fix: YAML frontmatter indentation in E2E tests, event statuses, and legacy req status support#90
Looted merged 2 commits intodevelopfrom
copilot/sub-pr-89

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 19, 2026

All 8 branch-workflow E2E tests were failing due to invalid YAML frontmatter in test fixtures, and the Prolog current_req/1 predicate silently excluded requirements with legacy status values.

Changes

  • YAML frontmatter (branch-workflow.test.ts, hook-integration.test.ts): Fixed 17 template literals where status: had a stray leading space, making it an invalid YAML mapping key. kibi sync silently produced no entities, causing every downstream assertion to fail:

    # before — invalid, parsed as child of previous key
    type: req
     status: open
    
    # after
    type: req
    status: open
  • Event statuses (scripts/populate-kb.ts): Changed EVT-001–EVT-005 from status: "passing""active". passing is a test entity lifecycle value; the extractor default for event is active.

  • current_req/1 (packages/core/src/kb.pl): Added legacy statuses active and approved to the accepted set alongside canonical open/in_progress/closed. Requirements stored with those values were silently dropped from contradiction checks and any inference depending on current_req/1.


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

…cy req statuses

Co-authored-by: Looted <6255880+Looted@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix vscode extension and improve unit test coverage fix: YAML frontmatter indentation in E2E tests, event statuses, and legacy req status support Mar 19, 2026
Copilot AI requested a review from Looted March 19, 2026 13:10
@Looted Looted marked this pull request as ready for review March 19, 2026 13:29
Copilot AI review requested due to automatic review settings March 19, 2026 13:29
@Looted Looted merged commit b5854fc into develop Mar 19, 2026
1 check passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes failing packed E2E tests caused by invalid YAML frontmatter in test fixtures, aligns seeded KB event entities with the correct lifecycle status, and restores current_req/1 behavior to include requirements using legacy status values so they aren’t silently excluded from inference/checks.

Changes:

  • Fixed YAML frontmatter indentation in packed E2E test fixtures so status: is a valid top-level key.
  • Updated seeded domain event entities (EVT-001–EVT-005) from status: "passing" to status: "active".
  • Extended current_req/1 to treat legacy requirement statuses (active, approved) as “current” alongside canonical statuses.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
scripts/populate-kb.ts Aligns seeded event entity statuses with expected lifecycle (active).
packages/core/src/kb.pl Expands current_req/1 to include legacy requirement statuses for backward compatibility.
documentation/tests/e2e/packed/hook-integration.test.ts Fixes invalid YAML frontmatter in requirement fixtures used by hook workflow E2E tests.
documentation/tests/e2e/packed/branch-workflow.test.ts Fixes invalid YAML frontmatter in requirement fixtures used by branch workflow E2E tests.

You can also share your feedback on Copilot code review. Take the survey.

@Looted Looted deleted the copilot/sub-pr-89 branch March 20, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants