Conversation
…cy req statuses Co-authored-by: Looted <6255880+Looted@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix vscode extension and improve unit test coverage
fix: YAML frontmatter indentation in E2E tests, event statuses, and legacy req status support
Mar 19, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes failing packed E2E tests caused by invalid YAML frontmatter in test fixtures, aligns seeded KB event entities with the correct lifecycle status, and restores current_req/1 behavior to include requirements using legacy status values so they aren’t silently excluded from inference/checks.
Changes:
- Fixed YAML frontmatter indentation in packed E2E test fixtures so
status:is a valid top-level key. - Updated seeded domain event entities (EVT-001–EVT-005) from
status: "passing"tostatus: "active". - Extended
current_req/1to treat legacy requirement statuses (active,approved) as “current” alongside canonical statuses.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/populate-kb.ts | Aligns seeded event entity statuses with expected lifecycle (active). |
| packages/core/src/kb.pl | Expands current_req/1 to include legacy requirement statuses for backward compatibility. |
| documentation/tests/e2e/packed/hook-integration.test.ts | Fixes invalid YAML frontmatter in requirement fixtures used by hook workflow E2E tests. |
| documentation/tests/e2e/packed/branch-workflow.test.ts | Fixes invalid YAML frontmatter in requirement fixtures used by branch workflow E2E tests. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 8 branch-workflow E2E tests were failing due to invalid YAML frontmatter in test fixtures, and the Prolog
current_req/1predicate silently excluded requirements with legacy status values.Changes
YAML frontmatter (
branch-workflow.test.ts,hook-integration.test.ts): Fixed 17 template literals wherestatus:had a stray leading space, making it an invalid YAML mapping key.kibi syncsilently produced no entities, causing every downstream assertion to fail:Event statuses (
scripts/populate-kb.ts): Changed EVT-001–EVT-005 fromstatus: "passing"→"active".passingis atestentity lifecycle value; the extractor default foreventisactive.current_req/1(packages/core/src/kb.pl): Added legacy statusesactiveandapprovedto the accepted set alongside canonicalopen/in_progress/closed. Requirements stored with those values were silently dropped from contradiction checks and any inference depending oncurrent_req/1.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.