Merged
Conversation
LordRaydenMK
force-pushed
the
marvel_to_themoviedb
branch
3 times, most recently
from
1316353 to
00070c3
Compare
LordRaydenMK
force-pushed
the
marvel_to_themoviedb
branch
from
7a2bbbd to
765e61d
Compare
hoc081098
reviewed
Oct 5, 2025
app/src/main/java/io/github/lordraydenmk/themoviedbapp/movies/data/movies.kt
Show resolved
Hide resolved
| import okhttp3.HttpUrl | ||
| import okhttp3.HttpUrl.Companion.toHttpUrl | ||
|
|
||
| typealias MovieId = Long |
There was a problem hiding this comment.
I think inline value class should be used instead of typealias
LordRaydenMK
force-pushed
the
marvel_to_themoviedb
branch
from
5a8fba5 to
baaa126
Compare
LordRaydenMK
force-pushed
the
marvel_to_themoviedb
branch
from
baaa126 to
74b34e3
Compare
LordRaydenMK
force-pushed
the
marvel_to_themoviedb
branch
from
7ab21e5 to
f88030e
Compare
LordRaydenMK
force-pushed
the
marvel_to_themoviedb
branch
2 times, most recently
from
ced89e9 to
68e4265
Compare
LordRaydenMK
force-pushed
the
marvel_to_themoviedb
branch
from
68e4265 to
7be7ca4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marvel killed their developer API. This app now uses TMDB API and shows movies.