fix: Remove redundant path from arm release#191
Merged
Losses merged 1 commit intoLosses:masterfrom Dec 11, 2024
Fei1Yang:linux-arm-release-bundle
Merged
fix: Remove redundant path from arm release#191Losses merged 1 commit intoLosses:masterfrom Fei1Yang:linux-arm-release-bundle
Losses merged 1 commit intoLosses:masterfrom
Fei1Yang:linux-arm-release-bundle
Conversation
Reviewer's Guide by SourceryThis PR modifies the ARM release packaging process in CircleCI to remove a redundant No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @Fei1Yang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync arm release to have the same behavior x86 release currently has, with no
bundleroot directory in it's release package.Summary by Sourcery
Align ARM release packaging with x86 by removing the redundant 'bundle' directory from the release package and updating the CI configuration accordingly.
Bug Fixes:
CI: