TR3 SFX and Secret Flipmap Triggers#249
Merged
DanzaG merged 4 commits intoLostArtefacts:masterfrom Nov 12, 2021
Merged
Conversation
Sequence-based mods should only run if level sequencing has been changed. As this setting is stored in the script config, a new variable has been added to access this from the level editing perspective and so TR3SequenceProcessor will only run when this is set.
- All sound effects for TR3 have been categorised. - New categories added for enemies that are alerted (Hey/Oi!) and for flying enemies. - TRSFXDefinition updated to use generics to allow the same format between TR2/3 (and others when the time comes). - Shared logic for populating the categories to target based on user settings has been moved to AudioRandomizer, and TR2AudioRandomizer updated accordingly. - Minor change to TR2 SFX definitions to categorise crow and eagle wing flapping (although the difference in actual sound is quite subtle).
If a secret is being added to a room that has an alternate room, the trigger will also be added to the alternate room FD. In addition, a check is now performed to ensure that no secrets will be placed in flipped rooms (unless development mode is on, in which case a warning message is printed). The UFO trapdoor in Area51 will now have its antitriggers removed so that the reward rooms can be reached if the final secret is inside the UFO.
Moves a secret from a flipped room into its original room in Jungle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#247 SFX
Resources\TR3\Audio\sfx.json.TRSFXDefinitionhas been updated to use generics to allow the same format to be used between TR2/3. So for TR2,TRSoundDetailsare defined in the JSON, for TR3 it'sTR3SoundDetails.AudioRandomizer, andTR2AudioRandomizerhas been updated accordingly. The logic for selecting new sounds remains somewhat duplicated in the TR2 and 3 classes, but this is mainly to allow for handling the differences in importing the sound.Closes #247.
#248 Flipmap Secret Triggers
If a secret is being added to a room that has an alternate room, the trigger will also be added to the alternate room's FD. In addition, a check is now performed to ensure that no secrets will be placed in flipped rooms (unless development mode is on, in which case a warning message is printed).
The UFO trapdoor in Area51 will now have its antitriggers removed so that the reward rooms can be reached if the final secret is inside the UFO.
Moved a secret from room 12 to room 113 in Jungle as room 12 is a flipped room.
#219 Sequencing Amendment
Sequence-based mods will now only run if level sequencing has been selected. As this setting is stored in the script config, a new variable has been added to
RandomizerSettingsto access this from the level editing perspective and soTR3SequenceProcessorwill only run when this is set.Closes #219 - remaining randomizers will be implemented under the separate issues raised by @DanzaG.