Conversation
7c5e23e to
19b54b1
Compare
chreden
left a comment
There was a problem hiding this comment.
Might be worth adding a dotnet test step? Not sure if there are any unit tests, but would mean you wouldn't have to change anything if any were added. I don't think it will fail if there are no tests but would be worth trying first.
Thanks, I did think about this too, but all the unit tests need local copies of the level files for 1-5. We don't keep these in the repository (and I don't think we should). The tests do need expanding on so I agree it would be good to add this. I think we can exclude the ones above using this.
|
Ignores the actual tests for now as the level files are needed.
The proof will be in the pudding with this one, but I've tested it on a private repository and it looks OK. I'll leave the issue open in case any tweaks are needed after it runs.
The change in
TR2ItemRandomizergets rid of a compiler warning (unused var, seems to have been introduced here) so the output should be clean, and the post build update is a guard in case$(TargetDir)contains spaces.I also realised with the SDK update recently that we switched to x64 builds so I think going forward we should release both as it's been x86 up until now.
One issue I think is that the packages will be double-zipped, but when releasing we can stick to manual uploads for now. The main purpose of this is for easier QA testing.
https://github.com/actions/upload-artifact#zipped-artifact-downloads