Merged
Conversation
assembly.CodeBase is obsolete, but our use of it is a fallback anyway. Part of LostArtefacts#425.
Part of LostArtefacts#425.
Part of LostArtefacts#425.
Part of LostArtefacts#425.
rr-
reviewed
Jul 22, 2023
| UseShellExecute = true | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you think it'd be useful to have similar class for file dialogs?
Collaborator
Author
There was a problem hiding this comment.
Good idea, a bit tidier and useful if we need to change something again in the future. New commit in with the update.
rr-
approved these changes
Jul 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers stage 1 of the migration to .NET Core 6, with the minimum
*.cschanges needed to comply.publishrather thanbuildand uses the new format for specifying the output folder. The publish profile details are in the csproj file - so this generates a single file now and we no longer need to move the DLLs into a sub-folder.See https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/7.0/solution-level-output-no-longer-valid
WindowsAPICodePackUI dialogs with those built-in (this was used previously as it was the only way to access the more user-friendly directory picker).UpdateChecker.csandApp.xaml.cs.UseShellExecute.See https://learn.microsoft.com/en-us/dotnet/core/compatibility/fx-core#change-in-default-value-of-useshellexecute
RectanglePackerandTRGE.Those projects that have
net6.0-windowstargets use - either directly or indirectly -System.Drawing.Bitmap. We may migrate to a different .NET Core universal drawing solution in the future, but this will be a big task in itself, and currently we only target Windows anyway so it's not a deal-breaker.The
usingupdate inTR2Roomis to fix a compiler error; stage 2 of the migration will be to fully update all usings to the minimum required.