Skip to content

Migrate to .NET Core 6#505

Merged
lahm86 merged 9 commits intoLostArtefacts:masterfrom
lahm86:issue-425-net6core
Jul 23, 2023
Merged

Migrate to .NET Core 6#505
lahm86 merged 9 commits intoLostArtefacts:masterfrom
lahm86:issue-425-net6core

Conversation

@lahm86
Copy link
Copy Markdown
Collaborator

@lahm86 lahm86 commented Jul 22, 2023

This covers stage 1 of the migration to .NET Core 6, with the minimum *.cs changes needed to comply.

Those projects that have net6.0-windows targets use - either directly or indirectly - System.Drawing.Bitmap. We may migrate to a different .NET Core universal drawing solution in the future, but this will be a big task in itself, and currently we only target Windows anyway so it's not a deal-breaker.

The using update in TR2Room is to fix a compiler error; stage 2 of the migration will be to fully update all usings to the minimum required.

@lahm86 lahm86 added this to the 1.8.0 milestone Jul 22, 2023
@lahm86 lahm86 requested review from chreden, makotocchi and rr- July 22, 2023 12:54
UseShellExecute = true
});
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it'd be useful to have similar class for file dialogs?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, a bit tidier and useful if we need to change something again in the future. New commit in with the update.

@lahm86 lahm86 merged commit 4596249 into LostArtefacts:master Jul 23, 2023
@lahm86 lahm86 deleted the issue-425-net6core branch July 23, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants