Merged
Conversation
Part of LostArtefacts#507.
rr-
reviewed
Aug 7, 2023
| _reader1 = new TR1LevelReader(); | ||
| _reader3 = new TR3LevelReader(); | ||
| _reader1 = new TR1LevelControl(); | ||
| _reader3 = new TR3LevelControl(); |
Collaborator
Author
There was a problem hiding this comment.
Yes, I missed quite a few of these, so updated now.
We have lots of messages like this since migrating to .NET Core, I should aim to fix these while editing the affected files. Ideally this number will eventually become 0.
There was a problem hiding this comment.
Maybe this could be tackled soon so that the PRs / CRs don't get polluted with stylistic comments?
Also there's the noise from the GH Actions bot.
Collaborator
Author
There was a problem hiding this comment.
Thanks, I'll organise some cleanup PRs for this.
rr-
approved these changes
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each
TRXLevelReaderandTRXLevelWriterhas been merged intoTRXLevelControl. The writing logic still remains within the level classes themselves, the next stage will involve separating out common code and further streamlining the control classes. Ultimately, the level classes will primarily be data structures and all IO logic handled in the control classes.One gotcha was with multithreading in the randomizer itself (
AbstractLevelProcessorand children) - the locks here are now shared instead of one for reading and another for writing.Additionally, tests now use memory streams instead of writing to disk.
Part of #507.