Cleanup level control project#524
Merged
lahm86 merged 20 commits intoLostArtefacts:masterfrom Aug 10, 2023
Merged
Conversation
Collaborator
Author
Yes, it's unused. I think it was put in place as it's mentioned here but this relates to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup tasks for the
TRLevelControlproject and its tests. The only thing out of the ordinary in this PR compared to the other cleanups is the additional refactoring in the level name classes - this brings TR1-3 into line with the new format added earlier for TR4/5.I've also removed a couple of unused classes and a few other methods - the TR5 room methods here are currently redundant as only the raw data is stored in the levels. This will be parsed fully in the future using a different approach.
There is much more refactoring to come for this project, but it will be continued under #507.