tr1/savegame_bson: handle Lara animation shift#2661
Merged
lahm86 merged 1 commit intoLostArtefacts:developfrom Mar 21, 2025
Merged
tr1/savegame_bson: handle Lara animation shift#2661lahm86 merged 1 commit intoLostArtefacts:developfrom
lahm86 merged 1 commit intoLostArtefacts:developfrom
Conversation
Prior to 4.8, Lara's legacy animation set could still be referenced from old savegames, but the case now is that only applicable animations are setup during level load. This shifts Lara's animation index to match her object if detected on load; a similar approach is already in place for TombATI saves. Resolves LostArtefacts#2654.
lahm86
force-pushed
the
issue-2654-sg-crash
branch
from
21b68cb to
204603a
Compare
|
Download the built assets for this pull request: |
rr-
approved these changes
Mar 21, 2025
Collaborator
rr-
left a comment
rr-
left a comment
There was a problem hiding this comment.
Wish we had unit tests for code like this, that is vulnerable to accidental refactors.
aredfan
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2654.
Checklist
Description
Prior to 4.8, Lara's legacy animation set could still be referenced from old savegames, but the case now is that only applicable animations are setup during level load, so after injections have reset the Lara object with the new values. This update shifts Lara's animation index to match her object if detected on load; a similar approach is already in place for TombATI saves.