Merged
Conversation
Owner
|
Very nice - what error happens if tkinter is loaded? |
Collaborator
Author
|
No error metal just needs its own backend screen with GPU layers exposed. No Blas is not a good fit for it. |
Owner
|
Oh, but this currently has no metal support correct? |
Collaborator
Author
|
It does, it works as well as the non prebuilt does we solved the issues with metal. |
LostRuins
pushed a commit
that referenced
this pull request
Aug 6, 2024
* OSX attempt 1 * OSX Pyinstaller * Update kcpp-build-release-osx.yaml * Update kcpp-build-release-osx.yaml * Update kcpp-build-release-osx.yaml * Add .metal file * Update kcpp-build-release-osx.yaml * Polish Mac (cherry picked from commit 52cc0da)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With some help of M.Holy I managed to find the issue with the metal pyinstaller, this CI should build and then test the binary for MacOS.
Mac still needs some overhauls for the UI since they can't input the gpulayers, and ideally we find a way to auto detect layers. But for now this at least allows binary builds.