Merged
Conversation
Removed redundant Node.js installation checks and related menu options. Now, if npm is not installed, the controller immediately opens the Node.js website and exits, streamlining the user experience. Also added an MIT license header to the file.
Updated the wrangler devDependency from 4.20.0 to 4.20.5 in package.json and package-lock.json. This also updates related dependencies such as workerd, miniflare, and @cloudflare packages to their latest compatible versions.
Advanced the CommonUtilities submodule pointer from 0e06b1d to 3456570 to incorporate the latest changes from the submodule.
Replaces the previous complex ProcessService with a minimal implementation focused on running external commands using system PATH. Removes configuration, diagnostics, and tool-specific logic, leaving only basic process execution and output streaming methods.
Introduced a function to handle and validate user input, improving the robustness of the input processing workflow.
Updated process execution methods to use '/c' instead of '/k', disable shell execution, and capture standard output and error streams. Deprecated RunProcessInNewCmdWindow in favor of RunProcess, and improved error handling and logging for better diagnostics.
Updated controllers to use RunProcessInNewCmdWindow for long-running or interactive commands (Composer, NPM, Artisan, Git), improving user experience by opening new terminal windows where appropriate. Switched to RunProcessWithStreaming for commands where immediate output is useful. Simplified error handling and removed deprecated or redundant logic. Updated ProcessService to properly open new cmd windows and removed obsolete attribute.
Advanced the CommonUtilities submodule reference from 3456570 to e492dcb to incorporate the latest changes and improvements from the submodule.
Replaced all process execution logic in ProcessService with calls to ProcessExecutionHelper methods. This centralizes process handling and reduces code duplication by delegating process management to CommonUtilities.Helpers.Processes.
Updated AssemblyVersion and FileVersion in EasyKit.csproj from 4.1.4 to 4.1.5 to reflect a new release.
Updated the MyAppVersion definition from 4.1.4 to 4.1.5 in Common.iss, Release-win-x64.iss, and Release-win-x86.iss to prepare for a new release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the LaravelController in the
EasyKitproject, simplifying the codebase and improving usability. Key changes include the removal of redundant methods, consolidation of PHP and Composer command handling, and enhanced process execution for better user experience. Additionally, licensing information was added to relevant files.Codebase Simplification:
GetPhpPath,FindComposerCommand, andGetComposerPath, consolidating logic for PHP and Composer command execution. ([[1]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546L154-L299),[[2]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546L349-R253))ProcessServicemethods with streamlined implementations for running PHP, Composer, and Artisan commands, improving clarity and maintainability. ([[1]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546L42-R70),[[2]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546R92-R145),[[3]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546L424-R303))[[1]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546L60-R80),[[2]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546L324-R219))Usability Enhancements:
[[1]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546L324-R219),[[2]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546L349-R253),[[3]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546L455-L474))[EasyKit/Controllers/LaravelController.csR92-R145](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546R92-R145))Licensing Updates:
EasyKit/ConfigureService.csandEasyKit/Controllers/LaravelController.csto ensure proper attribution and open-source compliance. ([[1]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-50902cdcde61a794d629f5ec189e4e9658874a4d3e0f98e7d94fb38e0bad2ac1R1-R22),[[2]](https://github.com/LoveDoLove/EasyKit/pull/31/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546R1-L2))