Merged
Conversation
Advanced the CommonUtilities submodule reference to commit 0786266. This brings in the latest changes from the CommonUtilities repository.
Deleted the ConfigureService.cs file, which contained service configuration and logging setup for EasyKit. This may indicate a refactor or migration of service configuration responsibilities.
The ServiceProvider field was declared but not used in Program.cs. This commit removes the unused field to clean up the code.
Renamed ProcessService.cs to CmdService.cs and updated all references from ProcessExecutionHelper to CmdHelper to reflect the new naming and helper class. This improves clarity and aligns with the updated CommonUtilities.Helpers.Command namespace.
Refactored all controller classes to use CmdService instead of ProcessService for process execution. Updated constructor dependencies and instantiations accordingly to ensure consistency across the application.
Deleted Serilog and System.Text.Json package references from EasyKit.csproj, likely because they are no longer needed or have been replaced.
Updated AssemblyVersion and FileVersion in EasyKit.csproj from 4.1.5 to 4.1.6 to reflect the new release.
Updated the MyAppVersion definition from 4.1.5 to 4.1.6 in Common.iss, Release-win-x64.iss, and Release-win-x86.iss to reflect the new application version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve the maintainability, consistency, and functionality of the
EasyKitproject. Key updates include replacingProcessServicewithCmdServiceacross the codebase, removing unused dependencies, and incrementing the project version. Additionally, theCmdServiceimplementation has been updated to useCmdHelperinstead ofProcessExecutionHelper, and theConfigureServiceutility has been removed.Codebase Refactoring:
ProcessServicewithCmdServicein all controllers (ComposerController,GitController,LaravelController,NpmController, andToolMarketplaceController) for better alignment with the updated service naming convention. ([[1]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-c6ca1958b5dc805628573cadc6a1e31d39d77ab9b5c4e4103336148f6eaae8a5L38-R38),[[2]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-c6ca1958b5dc805628573cadc6a1e31d39d77ab9b5c4e4103336148f6eaae8a5L54-R54),[[3]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-5077f3a6f342311e605541dde3488ce6f0b2be7c82ec68938da4c27f547eb4dfL36-R36),[[4]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-5077f3a6f342311e605541dde3488ce6f0b2be7c82ec68938da4c27f547eb4dfL52-R52),[[5]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546L36-R36),[[6]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-1ebf7585cad88bc0d73dfaca413865c9144803d8fd2734c0115e270889fbf546L52-R52),[[7]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-2dd925214250d1d6dfa9c9fd20bddbaff4c5786afc1401c24d10646a5e36d95cL40-R40),[[8]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-2dd925214250d1d6dfa9c9fd20bddbaff4c5786afc1401c24d10646a5e36d95cL56-R56),[[9]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-bd8939ae7c2fe1f6f49c8a801f81f0b960664217b830e5980e0bec5ae7ac278aL41-R43),[[10]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-54c5f447f34d3f69928b2bc6c0dec5caec53bcfa3dafb9220a79e844b4e8046fL62-R61))ProcessService.cstoCmdService.csand updated its methods to useCmdHelperinstead ofProcessExecutionHelper. ([[1]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-ec3e6866361e76e21bf7a202783b822ed05bb3f5f85d3212ad7350c815c14825L23-R30),[[2]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-ec3e6866361e76e21bf7a202783b822ed05bb3f5f85d3212ad7350c815c14825L43-R43),[[3]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-ec3e6866361e76e21bf7a202783b822ed05bb3f5f85d3212ad7350c815c14825L53-R53),[[4]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-ec3e6866361e76e21bf7a202783b822ed05bb3f5f85d3212ad7350c815c14825L62-R62))Dependency Cleanup:
SerilogandSystem.Text.Jsondependencies from theEasyKit.csprojfile. ([EasyKit/EasyKit.csprojL49-L55](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-07493134b6ab8de0df16cc01b816b2497a2ab8bed1baa7399247a8343333c5f1L49-L55))Version Increment:
4.1.5to4.1.6inEasyKit.csprojand relevant Inno Setup script files (ISS/Common.iss,ISS/Release-win-x64.iss,ISS/Release-win-x86.iss). ([[1]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-07493134b6ab8de0df16cc01b816b2497a2ab8bed1baa7399247a8343333c5f1L19-R20),[[2]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-560609c3c7682ee70041e6c3d4d58b4aa6f05e090ff40f9b7f0c76a6746d3601L7-R7),[[3]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-996a8d100d7869963e78681fad00169a90b87940b7853403dd676dc8c89ba618L5-R5),[[4]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-1abc26e5665aa0d2248f7d990c6d482d474ccb85246c9f2e6a28edc5f6083239L5-R5))Utility Removal:
ConfigureServiceutility and its usage inProgram.cs, simplifying the initialization process. ([[1]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-50902cdcde61a794d629f5ec189e4e9658874a4d3e0f98e7d94fb38e0bad2ac1L1-L43),[[2]](https://github.com/LoveDoLove/EasyKit/pull/32/files#diff-54c5f447f34d3f69928b2bc6c0dec5caec53bcfa3dafb9220a79e844b4e8046fL39))