Disabling Tools on Fresh Install, but not having ROMS will lead to getting Stuck on Black Screen

[farfenkugell]

It is very specific scenario that has happened to me on both Flip and Trimui Brick Hammer:

• Fresh install
• No roms added
• No games\anything in recent menu (recent menu is not there)
• Disabling Tools menu from main screen

Once you are done disabling Tools and try to get back to home page you will get stuck on Black screen.

• There wont be battery\wifi\clock on top right
• There wont be bottom Power\Sleep or A Open menu
• Quick menu button will not react
• You will be just stuck on black screen
• Force PowerOff and then adding ROMS fixes that

[ericreinsmidt]

I was able to reproduce this. There are some places in nextui.c that try to access top->entries->items[top->selected] without checking if the list is empty. Without Tools or ROMs it's undefined. I have a fix and just added some total>0 guards. Here's how it looks with them in place. You want me to change the message to something like "Add Some ROMs" or leave as-is before doing a PR?

[farfenkugell]

As long as we still have screen displaying UI it is fine.
It can be as in your screenshot.
Thank you.