Fix: Multi-file disc-based games not launching #609
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that when nextui.elf tried to exit (to launch a game), it got stuck in cleanupImageLoaderPool() because the animation worker thread was waiting for flipCond - a condition variable that signals frame readiness for animations. The main render loop normally signals this, but once the main loop exits (quit=1), it stops signaling, leaving the animation thread stuck forever.
Changes made:
cleanupImageLoaderPool(): Added SDL_CondSignal(flipCond) to wake up the animation thread during cleanup (Line 2158)
Animation frame loop: Added shutdown checks to break out early when workerThreadsShutdown is set (Line 2046 and 2066)
This allows nextui.elf to cleanly exit, the shell script's while loop to continue, and the game to launch via the /tmp/next command file.
This should fix #608