Skip to content

fix: rename Rewind_run_frame to run_frame and fix fast-forward logic#687

Merged
frysee merged 1 commit intoLoveRetro:mainfrom
Helaas:rewind-fastforward
Mar 23, 2026
Merged

fix: rename Rewind_run_frame to run_frame and fix fast-forward logic#687
frysee merged 1 commit intoLoveRetro:mainfrom
Helaas:rewind-fastforward

Conversation

@Helaas
Copy link
Copy Markdown

@Helaas Helaas commented Mar 21, 2026

Fixes the multiplied fast forward speed as reported in issue #677

@DrFlarp
Copy link
Copy Markdown

DrFlarp commented Mar 21, 2026

I've been thinking about the draw elision logic at minarch.c:5730. Instead of spreading the core.run calls evenly over t/n milliseconds, would it be better to race to get all n frames out ASAP and then do one longer wait call?

After all, frame pacing doesn't matter when it's all within a single vblank haha

Or revisit the elision line to something other than hardcoding 10ms there since it was based on a platform that we don't target?

@DrFlarp
Copy link
Copy Markdown

DrFlarp commented Mar 22, 2026

My concerns appear to be unfounded, this works great on all my testing scenarios with multiple workloads and FF speeds :)

@frysee frysee force-pushed the rewind-fastforward branch from 1730cac to 2241a21 Compare March 23, 2026 18:38
@frysee frysee merged commit 75420b1 into LoveRetro:main Mar 23, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants