fix: rename Rewind_run_frame to run_frame and fix fast-forward logic#687
Merged
frysee merged 1 commit intoLoveRetro:mainfrom Mar 23, 2026
Merged
fix: rename Rewind_run_frame to run_frame and fix fast-forward logic#687frysee merged 1 commit intoLoveRetro:mainfrom
frysee merged 1 commit intoLoveRetro:mainfrom
Conversation
|
I've been thinking about the draw elision logic at minarch.c:5730. Instead of spreading the core.run calls evenly over t/n milliseconds, would it be better to race to get all n frames out ASAP and then do one longer wait call? After all, frame pacing doesn't matter when it's all within a single vblank haha Or revisit the elision line to something other than hardcoding 10ms there since it was based on a platform that we don't target? |
|
My concerns appear to be unfounded, this works great on all my testing scenarios with multiple workloads and FF speeds :) |
1730cac to
2241a21
Compare
frysee
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the multiplied fast forward speed as reported in issue #677