Skip to content

Fix badge download cap at 256 preventing large achievement sets from fully downloading#689

Merged
frysee merged 1 commit intoLoveRetro:mainfrom
clintonium-119:missing-achievement-badges
Mar 23, 2026
Merged

Fix badge download cap at 256 preventing large achievement sets from fully downloading#689
frysee merged 1 commit intoLoveRetro:mainfrom
clintonium-119:missing-achievement-badges

Conversation

@clintonium-119
Copy link
Copy Markdown

Summary

  • Fixes badge images not downloading for games with large achievement sets (e.g. Pokemon Unbound being the largest with 844 achievements)
  • MAX_CACHED_BADGES was hardcoded to 256, but both locked and unlocked badge variants are cached per achievement, so any game with more than 128 achievements would silently drop badges
  • Increased limit from 256 to 2048 (supports up to 1,024 achievements), at a cost of ~184 KB of static memory on AArch64
  • Removed the redundant MAX_QUEUED_DOWNLOADS constant — the download queue and badge cache are structurally coupled and must always be the same size, so both now use MAX_CACHED_BADGES

@clintonium-119 clintonium-119 deleted the missing-achievement-badges branch March 23, 2026 17:46
@clintonium-119 clintonium-119 restored the missing-achievement-badges branch March 23, 2026 17:46
@frysee frysee merged commit cdec5b8 into LoveRetro:main Mar 23, 2026
124 checks passed
@clintonium-119 clintonium-119 deleted the missing-achievement-badges branch March 23, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants