Fix badge download cap at 256 preventing large achievement sets from fully downloading#689
Merged
frysee merged 1 commit intoLoveRetro:mainfrom Mar 23, 2026
Conversation
…fully downloading
frysee
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_CACHED_BADGESwas hardcoded to 256, but both locked and unlocked badge variants are cached per achievement, so any game with more than 128 achievements would silently drop badgesMAX_QUEUED_DOWNLOADSconstant — the download queue and badge cache are structurally coupled and must always be the same size, so both now useMAX_CACHED_BADGES