fix: crash on out-of-bound access when loading cheats

[nborodikhin]

Summary

I ran into a crash when running a debug build on the device with picodrive core. The crash is caused by populating a fixed size array without proper size check.

On game load, Cheat_getPaths() creates a list of paths to try to load cheats from. 5 entries are pre-configured, and the rest are dynamically populated using the extensions supported by the emulator core. The issue is that some predefined paths (like glob) are added to the list without proper checks after the core extensions are processed, and that causes writing outside of array memory.

Note that Picodrive core has 16 extensions supported, but there are upstream retroarch cores that support up to 42 extensions.

Change

• Cheat_getPaths():
  • increase the size of the cheat paths list to 48 paths
  • when processing extensions, reserve 3 entries for predefined paths/masks
• OptionCheats_openMenu():
  • using menu index i (passed in as a position parameter) to access cheat by index
  • iterated with j but indexed both cheatcodes.cheats and OptionCheats_menu.items with i

Test plan

• debug build of minarch runs SMS game with picodrive