Fix various diagnostics typos in settings.mdx and diagnostics.mdx#115
Merged
carsakiller merged 3 commits intoLuaLS:mainfrom Mar 17, 2026
Merged
Fix various diagnostics typos in settings.mdx and diagnostics.mdx#115carsakiller merged 3 commits intoLuaLS:mainfrom
carsakiller merged 3 commits intoLuaLS:mainfrom
Conversation
The conventions group was missing from the default values listed for diagnostics.groupFileStatus and diagnostics.groupSeverity settings.
Renamed global-elements to global-element in the default values listed for diagnostics.neededFileStatus and diagnostics.severity settings.
A duplicate cast-type-mismatch diagnostic entry was incorrectly listed in the luadoc group, in addition to the type-check group.
carsakiller
reviewed
Mar 17, 2026
Contributor
Author
|
Thanks for the quick review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues in the wiki, all related to diagnostics:
conventionsgroup was missing from the default values listed for thediagnostics.groupFileStatusanddiagnostics.groupSeveritysettingsglobal-elementdiagnostic was incorrectly referenced asglobal-elementsin the default values listed for thediagnostics.neededFileStatusanddiagnostics.severitysettingscast-type-mismatchdiagnostic was referenced twice in the diagnostics page: once in thetype-checkgroup (correct) and once in theluadocgroup (incorrect)