Formatter does not take into account Nonstandard Symbol setting

[jellyton255]

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Formatting

Expected Behaviour

The document should be formatting when the document contains one of the nonstandard symbols defined in settings.

Actual Behaviour

The document does not format.

Reproduction steps

1. Enter a non standard symbol into the non-standard symbol settings.
2. Add a non standard symbol into your document.
3. Attempt to format.
4. Fail

Additional Notes

Settings:

"Lua.runtime.nonstandardSymbol": ["/**/", "`", "+=", "-=", "*=", "/=", "<<=", ">>=", "&=", "|=", "^="]

Example:

Log File

log.log

[CppCXY]

because the formatting feature is not implemented by Sumneko LS itself, the formatting feature naturally does not support its nonstandard syntax.

[Gittified]

Thank god that you found out it was i += 1 because I just spent an hour trying to find out why my document was completely refusing to format without any errors or information. I was just about to give up when I found this

[CppCXY]

Your request has been implemented. you can check the formatting of non-standard symbols in the next version.

[Gittified]

Your request has been implemented. you can check the formatting of non-standard symbols in the next version.

Thank you very much for your great project and fast response!

[jellyton255]

Your request has been implemented. you can check the formatting of non-standard symbols in the next version.

Just curious, if I added "?" to the list of nonstandard symbols, will also allow formatting of a file that uses them like this:

[CppCXY]

I didn't see support for '?' in lua-language-server. The formatter just maps non-standard symbols to standard symbols. I admit that Lua lacks many commonly used and useful operators, but supporting so many non-standard symbols makes me feel like I'm not writing a Lua formatter.

[CppCXY]

Ok, I accept this symbol again, but I can only treat '?.' as '.'

[jellyton255]

Ok, I accept this symbol again, but I can only treat '?.' as '.'

Thank you very much. Just to make sure, there shouldn't be any unintended issues due to this right? If you're treating "?" as ".", it shouldn't consider it to be a concatenation as used here:

[CppCXY]

Ok, I accept this symbol again, but I can only treat '?.' as '.'

Thank you very much. Just to make sure, there shouldn't be any unintended issues due to this right? If you're treating "?" as ".", it shouldn't consider it to be a concatenation as used here:

It is "?." as ".", in my lexical analysis, the token kind has already been determined, so even if a '.' is added afterwards, it would only be a syntax error.

[CppCXY]

the latest version has been released, and your FR should be available now.