Fix name-style provider not using URI when loading config#3415
Fix name-style provider not using URI when loading config#3415D4isDAVID wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates script/provider/name-style.lua to pass the file's uri instead of nil when retrieving the Lua.nameStyle.config configuration. The reviewer pointed out that using a single global boolean flag m.loaded prevents proper configuration loading in multi-folder workspaces, as only the first folder's configuration is loaded. They suggested tracking the last loaded configuration value instead of a boolean flag to support multi-folder workspaces.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
854cfbd to
ad4fdf9
Compare
Currently, the initial
config.getcall forLua.nameStyle.configdoes not use the provided URI. This results in the initial name style config to be{}, ignoring any settings overrides.This PR provides a simple fix that uses the URI for the initial
config.getcall.Tested in Zed with a
.luarc.jsonfile.Fixes #2643.