Conversation
Co-authored-by: jwaspin <6432180+jwaspin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Data Refactor Phase 1: Add accountId to transactions
Data Refactor Phase 1: Add accountId to transactions with automatic migration
Oct 6, 2025
jwaspin
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Phase 1 of the data refactor by adding an
accountIdfield to all transaction objects and providing automatic migration for existing data. This prepares the codebase for a future unified transaction store by ensuring every transaction knows which account it belongs to.Changes
Transaction Schema & Data Model
accountIdfield to the transaction schema validationgenerateTransaction()to accept and includeaccountIdin all new transactionscreateNewTransaction,createRepeatTransaction) to passaccountIdwhen creating transactionsACCOUNT_IDconstant toTransactionFieldsenumRedux State Management
accountIdis set when transactions are added or updatedaccountIdwhen stored in account arraysAutomatic Migration
Implemented an idempotent migration in
store.jsthat:accountIdon app loadaccountIdfrom the parent account for existing transactionsaccountIdExample migration output:
Testing
Migration Testing
accountId- migration successfully backfilled the fieldNew Transaction Testing
accountIdis automatically includedaccountIdBuild & Lint
Acceptance Criteria
All acceptance criteria from the issue have been met:
Screenshots
Application running with version 1.9.0-rc.1 showing migrated data:
Impact
This change is backwards compatible and non-breaking:
Related Issues
Closes #[issue-number]
Depends on #50 (Data Refactor Phase 0: Rename Redux slices to legacy)
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.