Fix unlink command failing on dangling symlinks#60
Merged
albertodebortoli merged 1 commit intomainfrom Apr 10, 2026
Merged
Conversation
fileExists follows symlinks, so it returned false for dangling symlinks left behind after a tool was uninstalled. Switch to attributesOfItem which does not follow symlinks, allowing the unlinker to detect and remove dangling symlinks while informing the user that the underlying tool is not installed.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
luca unlink <tool>failed withError: Symlink '<tool>' not found.becausefileExistsfollows symlinks and returnsfalsefor dangling ones.attributesOfItemwhich does not follow symlinks, so the unlinker can detect and remove dangling symlinks.Type of Change
How Has This Been Tested?
New test
unlink_danglingSymlink_removesSymlinkcreates a real dangling symlink and verifies it gets cleaned up. Existingunlink_symlinkNotFoundtest confirms the error is still thrown when no symlink exists.Checklist
Breaking Changes?