Fix installQuietly showing success message with no tools or skills#61
Merged
albertodebortoli merged 1 commit intomainfrom Apr 11, 2026
Merged
Conversation
…e defined The quiet install paths for both tools and skills ran the full progressStep (including the "installed" success message) even when nothing was found. The verbose counterparts already guarded against this with an isEmpty check. Move detection before the progressStep and early-return when the list is empty, matching the verbose behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
installQuietly) for both tools and skills ran the fullprogressStep— including the "installed" success message — even when no tools or skills were defined in the spec.installVerbose) already guarded against this with anisEmptycheck.progressStepand added an early return when the list is empty, matching the verbose behavior.Type of Change
How Has This Been Tested?
swift test— 356 tests, all passing)swift build)Checklist
Breaking Changes?
🤖 Generated with Claude Code