Check version exists on GitHub before downloading#64
Merged
albertodebortoli merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
Adds a pre-download API call to the GitHub Releases endpoint for the specific tag. A 404 response now throws a clear `versionNotFound` error instead of letting the download silently fetch an HTML page and then fail with a cryptic `extractionFailed` from unzip.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
albertodebortoli
deleted the
feature/version-existence-check-before-download
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Check version exists on GitHub before downloading
Description
SelfUpdater.performUpdatepreviously attempted to download a release ZIP without verifying the version exists on GitHub first. When the version was absent (e.g. a typo in.luca-version), the download would silently fetch an HTML 404 page, thenunzipwould fail, producing a crypticextractionFailederror./releases/tags/{version}). A 404 response now throws a clearversionNotFounderror with a message pointing the user to their.luca-versionfile. Any other response (200, 5xx, network errors) lets the flow proceed unchanged so existing behaviour is unaffected.Type of Change
How Has This Been Tested?
test_updateIfNeeded_versionNotFound_throwsVersionNotFound— verifies a 404 from the GitHub API throwsSelfUpdater.SelfUpdaterError.versionNotFound. All 30SelfUpdaterTestspass.Checklist
Breaking Changes?
Additional Notes
Non-404 responses (5xx, network errors) deliberately do not throw — the flow falls through to the download, which will surface its own error if the release truly cannot be reached. This avoids blocking users on transient API failures.