Fix desiredBinaryName being ignored when installing from archives#71
Merged
albertodebortoli merged 1 commit intomainfrom Apr 14, 2026
Merged
Fix desiredBinaryName being ignored when installing from archives#71albertodebortoli merged 1 commit intomainfrom
albertodebortoli merged 1 commit intomainfrom
Conversation
When a tool was installed from a zip or tar.gz archive, `desiredBinaryName` was discarded: `installArchive` hardcoded `desiredBinaryName: nil` in the `resolvedTool` it passed to `PermissionManager` and `SymLinker`. As a result, the symlink used the in-archive binary name instead of the desired one. The fix renames the extracted binary to `desiredBinaryName` in the cache before building `resolvedTool`, mirroring the behaviour of `installExecutable`. A regression test covering the Phrase CLI scenario is added.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Fix desiredBinaryName being ignored when installing from archives
Description
desiredBinaryNamewas silently discarded.installArchivehardcodeddesiredBinaryName: nilwhen constructing theresolvedToolpassed toPermissionManagerandSymLinker, so the symlink always used the in-archive binary filename instead of the desired name.installExecutable) worked correctly because it renames the downloaded file todesiredBinaryNamebefore storing it in the cache.installArchive: after extraction, ifdesiredBinaryNameis set, the binary is moved from its extracted path todesiredBinaryNamewithin the installation destination.resolvedToolis then built with the updated path, makingPermissionManagerandSymLinkerboth point to the correct (renamed) file.binaryPath: phrase_macosx_arm64,desiredBinaryName: phrase) — symlink was namedphrase_macosx_arm64instead ofphrase.Type of Change
How Has This Been Tested?
test_install_archiveWithDesiredBinaryName_usesDesiredNameForSymlinkcovers the Phrase scenario end-to-end throughToolInstallerChecklist
CI Considerations
Breaking Changes?
Additional Notes
The root cause was a single
desiredBinaryName: nilline ininstallArchive(introduced when theresolvedToolpattern was added). The executable path never had this bug because it physically renames the file on download.