Prevent luca install from running in the home directory#72
Merged
albertodebortoli merged 2 commits intomainfrom Apr 14, 2026
Merged
Prevent luca install from running in the home directory#72albertodebortoli merged 2 commits intomainfrom
albertodebortoli merged 2 commits intomainfrom
Conversation
Running `luca install` from `~` causes `symlinksFolder` to resolve to the same path as `toolsFolder` (~/.luca/tools/), corrupting the tool cache. Throw a clear error when the current directory is the home directory.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Prevent luca install from running in the home directory
Description
luca installis run from~,symlinksFolder(.luca/tools/relative to CWD) resolves to~/.luca/tools/— the same path as the global tool cache (toolsFolder). This causes symlink creation to conflict with versioned tool directories, corrupting the cache structure.InstallerError.runningFromHomeDirectorywith a clear message before any installation begins when CWD equals the home directory.Type of Change
How Has This Been Tested?
Added parameterized test
test_install_fromHomeDirectory_throwsErrorcovering bothquiet: trueandquiet: falsepaths. Verified thatInstaller.InstallerError.runningFromHomeDirectoryis thrown and the error message is correct.swift test --filter InstallerTestsChecklist
Breaking Changes?
Additional Notes
The check uses a plain string comparison (
fileManager.currentDirectoryPath != fileManager.homeDirectoryForCurrentUser.path) rather thanURL-based comparison to avoid macOS symlink resolution (/var→/private/var) causing false negatives in tests.