Actionable error for missing global Lucafile and hoist duplicated scope variable#79
Merged
albertodebortoli merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
…duplicated scope variable - Add InstallCommandError.globalLucafileMissing and guard in InstallCommand.run() so `luca install --global` with no Lucafile at ~/.config/luca/Lucafile surfaces a clear "No global Lucafile found ... Create one to get started." message instead of a raw file-not-found error from SpecLoader. - Hoist the duplicated `scope` variable in Installer.installVerbose(installationType:useNpx:isGlobal:) to a single declaration before the if/else branches.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Actionable error for missing global Lucafile and hoist duplicated scope variable
Description
InstallCommandError.globalLucafileMissingso thatluca install --globalwith no Lucafile at~/.config/luca/Lucafilesurfaces a clear, actionable error message ("No global Lucafile found at … Create one to get started.") instead of a raw file-not-found fromSpecLoader.scopevariable inInstaller.installVerbose(installationType:useNpx:isGlobal:)to a single declaration before the if/else branches.Type of Change
How Has This Been Tested?
Screenshots / Demo (if applicable)
N/A
Checklist
CI Considerations
Breaking Changes?
Additional Notes
No new tests added — the guard lives in
InstallCommand.run()wherefileManageris not injected, so a unit test would require a DI refactor of the command layer, which is out of scope here.