Fix few --use-current-year bugs#63
Merged
Lucas-C merged 1 commit intoLucas-C:masterfrom Jan 26, 2023
Merged
Conversation
Lucas-C
requested changes
Jan 25, 2023
Owner
Lucas-C
left a comment
Lucas-C
left a comment
There was a problem hiding this comment.
Thank you for coming back with some fixes!
Parse end years correctly if extra spacing is used. Stop searching for the year when the whole license header was searched. Stop changing four digit numbers that come after the header. Fail the check if the year update failed. Avoid creating a range with the current year used as both start and end. Add tests for cases when the header already contains the current year.
Contributor
Author
|
Thanks for the excellent suggestions :) I think I addressed all of them. |
Owner
|
Merged! |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse end years correctly if extra spacing is used.
Stop searching for the year when the whole license header was searched.
Stop changing four digit numbers that come after the header.
Fail the check if the year update failed.
Avoid creating a range with the current year used as both start and end.
Add tests for cases when the header already contains the current year.