Roles get team members api#202
Merged
JamesBirni merged 6 commits intomainfrom Mar 28, 2025
Merged
Conversation
… whether they are a team lead or not. Added new DTO class tests.
JamesBirni
approved these changes
Mar 28, 2025
Collaborator
JamesBirni
left a comment
JamesBirni
left a comment
There was a problem hiding this comment.
Seems to have fixed the issue with getTeamMembers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the API documentation to show that the role gets returned when getTeamMembers method is called for a specific team.
Changed the getTeamMembers method inside TeamService to return a boolean of whether they are a teamlead (true) or not (false). Created a new DTO that contains isTeamLead field, and added new ConvertToDTO method in TeamService.
Updated backend tests to use TeamMemberInTeamDTO instead of TeamMemberDTO.
Created DTO tests for the new DTO class TeamMemberInTeamDTO.
Updated API documentation to reflect the new field.
Resolves #193