Conversation
JamesBirni
changed the title
taoTimTim
approved these changes
Mar 28, 2025
Collaborator
taoTimTim
left a comment
taoTimTim
left a comment
There was a problem hiding this comment.
Syntax is correct. Running in frontend works properly, I can change the password from an admin's account and fromm a team members account.
The popups of "Failed to change password" and "Passwords don't match" are working great and correctly, having tested for both while running.
Great work, ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Within profile there is now a button to change the users password. It requires the old password, the new password, and a confirmation for the new password.
Error Handling
Once the password is changed, the user gets redirected to login
Resolves #217